qcom-base: set the PACKAGE_CLASSES with weak assignment#265
qcom-base: set the PACKAGE_CLASSES with weak assignment#265quaresmajose wants to merge 1 commit into
Conversation
This will allow you to redefine the variable outside the layer. Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
|
Why? What's the problem or the use case you are fixing? |
|
The purpose of a DISTRO is to have an opinion, if your opinion differs from that, use a different DISTRO. Weak assignments in a DISTRO should be carefully considered, but the package format should be consistent no matter what. |
It doesn't cause any problems for now, but it could if you try to change the package manager in a KAs fragment. |
When the meta-qcom-distro layer was created, it was using the distribution's package manager: package_ipk inherited from nodistro. What I want now is to standardize the package manager across the entire CI. What do you think we should do? |
I think we shouldn't be changing DISTRO settings in our CI. If a DISTRO is unsuited for our CI, we shouldn't use it, not pull a "It's Fedora, but we make it use .debs and musl" type of thing. The point for |
|
So should we revert #144 ? |
Why? That change is qcom-distro specific, which is fine. |
|
This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 5 days, remove the stale label or add a comment. You can reopen a closed pull request at any time. |
|
We are now using RPM also in nodistro qualcomm-linux/meta-qcom#2046. Therefore, what I intended by standardizing the package maneger is no longer necessary. |
This will allow you to redefine the variable outside the layer.