Skip to content

qcom-base: set the PACKAGE_CLASSES with weak assignment#265

Closed
quaresmajose wants to merge 1 commit into
qualcomm-linux:mainfrom
quaresmajose:package
Closed

qcom-base: set the PACKAGE_CLASSES with weak assignment#265
quaresmajose wants to merge 1 commit into
qualcomm-linux:mainfrom
quaresmajose:package

Conversation

@quaresmajose

Copy link
Copy Markdown
Contributor

This will allow you to redefine the variable outside the layer.

This will allow you to redefine the variable outside the layer.

Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
@lumag

lumag commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Why? What's the problem or the use case you are fixing?

@koenkooi

koenkooi commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

The purpose of a DISTRO is to have an opinion, if your opinion differs from that, use a different DISTRO. Weak assignments in a DISTRO should be carefully considered, but the package format should be consistent no matter what.

@quaresmajose

Copy link
Copy Markdown
Contributor Author

Why? What's the problem or the use case you are fixing?

It doesn't cause any problems for now, but it could if you try to change the package manager in a KAs fragment.

@quaresmajose

quaresmajose commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

The purpose of a DISTRO is to have an opinion, if your opinion differs from that, use a different DISTRO. Weak assignments in a DISTRO should be carefully considered, but the package format should be consistent no matter what.

When the meta-qcom-distro layer was created, it was using the distribution's package manager: package_ipk inherited from nodistro.
However, we started having problems with opkg a while ago and decided to switch to rpm.
However, this change was only made for the qcom-distro, while the nodistro remained with ipk.

What I want now is to standardize the package manager across the entire CI. What do you think we should do?

@koenkooi

Copy link
Copy Markdown
Contributor

The purpose of a DISTRO is to have an opinion, if your opinion differs from that, use a different DISTRO. Weak assignments in a DISTRO should be carefully considered, but the package format should be consistent no matter what.

When the meta-qcom-distro layer was created, it was using the distribution's package manager: package_ipk inherited from nodistro. However, we started having problems with opkg a while ago and decided to switch to rpm. However, this change was only made for the qcom-distro, while the nodistro remained with ipk.

What I want now is to standardize the package manager across the entire CI. What do you think we should do?

I think we shouldn't be changing DISTRO settings in our CI. If a DISTRO is unsuited for our CI, we shouldn't use it, not pull a "It's Fedora, but we make it use .debs and musl" type of thing.

The point for nodistro is that we test our layer in using an upstream config to see if our own DISTRO is hiding issues, altering the upstream config severely hampers that effort. And "our CI is slow" is most certainly not a valid reason to change upstream configs.

@quaresmajose

Copy link
Copy Markdown
Contributor Author

So should we revert #144 ?

@ricardosalveti

Copy link
Copy Markdown
Contributor

So should we revert #144 ?

Why? That change is qcom-distro specific, which is fine.

@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 5 days, remove the stale label or add a comment. You can reopen a closed pull request at any time.

@quaresmajose

Copy link
Copy Markdown
Contributor Author

We are now using RPM also in nodistro qualcomm-linux/meta-qcom#2046. Therefore, what I intended by standardizing the package maneger is no longer necessary.

@quaresmajose quaresmajose deleted the package branch May 11, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants